Aggregation updates #832
Open
Aggregation updates #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StepanBrychta
force-pushed
the
Aggregation-updates
branch
from
d78a698
to
ad48316
Compare
StepanBrychta
force-pushed
the
Aggregation-updates
branch
from
b4c189d
to
4cd967e
Compare
…ection/catalogue-api into Aggregation-updates
…ection/catalogue-api into Aggregation-updates
…ection/catalogue-api into Aggregation-updates
…ection/catalogue-api into Aggregation-updates
…ection/catalogue-api into Aggregation-updates
StepanBrychta
force-pushed
the
Aggregation-updates
branch
from
732be8c
to
ab96b63
Compare
StepanBrychta
force-pushed
the
Aggregation-updates
branch
from
ab96b63
to
63957de
Compare
StepanBrychta
force-pushed
the
Aggregation-updates
branch
2 times, most recently
from
b0a6815
to
55ed86f
Compare
StepanBrychta
force-pushed
the
Aggregation-updates
branch
from
55ed86f
to
eab08b3
Compare
StepanBrychta
force-pushed
the
Aggregation-updates
branch
2 times, most recently
from
747b1de
to
5cd04a4
Compare
StepanBrychta
force-pushed
the
Aggregation-updates
branch
from
5cd04a4
to
0b00044
Compare
kenoir
reviewed
Dec 3, 2024
| `source.genres.label`: Option[GenreFilter], | ||
| `source.genres.concepts`: Option[GenreConceptFilter], | ||
| `source.contributors.agent.label`: Option[ContributorsLabelFilter], | ||
| `source.contributors.agent.id`: Option[ContributorsIdFilter], |
There was a problem hiding this comment.
Is the use of .id in keeping with principle 1 in the API faceting RFC?
Filters are named by the JSON paths of the identified object that they filter or, if applied to an attribute other than the identifier, the path of that attribute
I would have expected the if filter to just be for example source.contributors.agent, omitting the ID?
There was a problem hiding this comment.
Yes, this should now be fixed
StepanBrychta
force-pushed
the
Aggregation-updates
branch
from
9cbb89f
to
153c8a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
wellcomecollection/platform#5825
Changes how we handle aggregations in Elasticsearch queries, following on changes to the catalogue pipeline.
The API now supports two aggregation types:
All existing production functionality should remain the same. From the frontend's perspective, the only change to the API involves renaming ID-based filters (
genres.concepts→genres), but the affected filters are only used behind a feature flag.Note
This branch has been rebased to #829.
Checklist
How to test
How can we measure success?
Added support for ID-based aggregations without negative side effects and without losing support for label-based concept aggregations.
Have we considered potential risks?